Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(omron_node): diagnostics for frequency #14

Merged
merged 2 commits into from
Apr 12, 2018
Merged

feat(omron_node): diagnostics for frequency #14

merged 2 commits into from
Apr 12, 2018

Conversation

reinzor
Copy link
Member

@reinzor reinzor commented Feb 5, 2018

No description provided.

@@ -113,6 +123,10 @@ int main(int argc, char *argv[])
laserscan_msg.header.seq++;
laserscan_pub.publish(laserscan_msg);

// Tick the frequency and update the diagnostics
frequency_status.tick();
updater.update();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@reinzor reinzor Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I was not aware of the DiagnosedPublisher, I will refactor this to the diagnosed publisher

@@ -41,6 +43,8 @@ using eip::socket::TCPSocket;
using eip::socket::UDPSocket;
using namespace omron_os32c_driver;

double RATE = 12.856;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameterize the expected rate and permitted deviation, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, any suggestions for naming?

  • ~expected_frequency (default=12.856)
  • ~frequency_tolerance (default=0.1)
  • ~timestamp_min_acceptable (default=-1)
  • ~timestamp_max_acceptable (default=5)

@reinzor
Copy link
Member Author

reinzor commented Mar 28, 2018

Can this one be merged?

@reinzor
Copy link
Member Author

reinzor commented Apr 12, 2018

ping

@mikepurvis
Copy link
Member

Looks great, thanks!

Note that I'm not actively using or maintaining this driver. If you're using it, are you interested in becoming the maintainer?

@mikepurvis mikepurvis merged commit b9487c5 into ros-drivers:indigo-devel Apr 12, 2018
@reinzor
Copy link
Member Author

reinzor commented Apr 13, 2018

Thanks Mike, I would be interested. Could you give me some pointers what it means to "maintain" a package. Does it also include https://github.com/ros-drivers/odva_ethernetip ?

@mikepurvis
Copy link
Member

Yes, you could definitely have both repos. I would give you permission to write them on github as well as their corresponding GBP repos for the purposes of creating releases.

See for more details: http://wiki.ros.org/MaintenanceGuide

@reinzor
Copy link
Member Author

reinzor commented Apr 16, 2018

Thanks. Sure I will maintain the packages. Thanks for the information regarding the responsibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants